From f2d83e57ea6e137d2e86f32c0c7ccbb86da769b2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Philipp=20H=C3=A4felfinger?= <philipp@haefelfinger.ch>
Date: Mon, 25 Mar 2019 23:36:25 +0100
Subject: [PATCH] optimized metadata create / update performance

---
 internal/app/images.go | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/internal/app/images.go b/internal/app/images.go
index 0107a5a..7c20fb6 100644
--- a/internal/app/images.go
+++ b/internal/app/images.go
@@ -51,7 +51,7 @@ func synchronizeLocalImageMetadataScanNewFiles(fileSystemNodes map[string]*local
 
 		metadata, err := metadataStorage.ImageMetadata(file.Path)
 		if err == ErrorRecordNotFound {
-			logrus.Debugf("No metadata for %s found. Creating new entry.", file.Key)
+			logrus.Debugf("Creating new metadata entry for %s.", file.Path)
 			metadata = ImageMetaData{}
 			metadata.Filename = file.Name
 			metadata.FullImagePath = file.Path
@@ -69,6 +69,11 @@ func synchronizeLocalImageMetadataScanNewFiles(fileSystemNodes map[string]*local
 			return err
 		}
 
+		if fileDidNotChange(&metadata, file) {
+			logrus.Debugf("No changes found for file %s", file.Path)
+			continue
+		}
+
 		metadata.UploadRequired = !metadata.LastChange.Equal(file.ModTime) || metadata.PiwigoId == 0
 		metadata.DeleteRequired = false
 		metadata.LastChange = file.ModTime
@@ -163,7 +168,7 @@ func deleteImages(piwigoCtx piwigo.PiwigoImageApi, metadataProvider ImageMetadat
 
 	logrus.Infof("Deleting %d images from piwigo", len(images))
 
-	piwigoIds := []int{}
+	var piwigoIds []int = nil
 	for _, img := range images {
 		if img.PiwigoId > 0 {
 			logrus.Tracef("Adding %d to deletable list", img.PiwigoId)
@@ -273,6 +278,7 @@ func updatePiwigoIdIfAlreadyUploaded(provider ImageMetadataProvider, piwigoCtx p
 	if err != nil {
 		return err
 	}
+
 	for md5sum, piwigoId := range missingResults {
 		if piwigoId > 0 {
 			logrus.Debugf("Setting piwigo id of %s to %d", md5sum, piwigoId)
@@ -287,3 +293,7 @@ func updatePiwigoIdIfAlreadyUploaded(provider ImageMetadataProvider, piwigoCtx p
 
 	return nil
 }
+
+func fileDidNotChange(metadata *ImageMetaData, file *localFileStructure.FilesystemNode) bool {
+	return metadata.LastChange.Equal(file.ModTime) && !metadata.DeleteRequired
+}
\ No newline at end of file