piwigo/PiwigoDirectoryUploader
2
0
Fork 0
Code Issues 3 Pull Requests Releases Wiki Activity

optimized metadata create / update performance

Browse Source
This commit is contained in:
Philipp Häfelfinger 2019-03-25 23:36:25 +01:00
parent 2e1c2c4e61
commit f2d83e57ea
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
internal/app/images.go
View File

@ -51,7 +51,7 @@ func synchronizeLocalImageMetadataScanNewFiles(fileSystemNodes map[string]*local
metadata, err := metadataStorage.ImageMetadata(file.Path) metadata, err := metadataStorage.ImageMetadata(file.Path)
if err == ErrorRecordNotFound { if err == ErrorRecordNotFound {
logrus.Debugf("No metadata for %s found. Creating new entry.", file.Key) logrus.Debugf("Creating new metadata entry for %s.", file.Path)
metadata = ImageMetaData{} metadata = ImageMetaData{}
metadata.Filename = file.Name metadata.Filename = file.Name
metadata.FullImagePath = file.Path metadata.FullImagePath = file.Path
@ -69,6 +69,11 @@ func synchronizeLocalImageMetadataScanNewFiles(fileSystemNodes map[string]*local
return err return err
} }
if fileDidNotChange(&metadata, file) {
logrus.Debugf("No changes found for file %s", file.Path)
continue
}
metadata.UploadRequired = !metadata.LastChange.Equal(file.ModTime) || metadata.PiwigoId == 0 metadata.UploadRequired = !metadata.LastChange.Equal(file.ModTime) || metadata.PiwigoId == 0
metadata.DeleteRequired = false metadata.DeleteRequired = false
metadata.LastChange = file.ModTime metadata.LastChange = file.ModTime
@ -163,7 +168,7 @@ func deleteImages(piwigoCtx piwigo.PiwigoImageApi, metadataProvider ImageMetadat
logrus.Infof("Deleting %d images from piwigo", len(images)) logrus.Infof("Deleting %d images from piwigo", len(images))
piwigoIds := []int{} var piwigoIds []int = nil
for _, img := range images { for _, img := range images {
if img.PiwigoId > 0 { if img.PiwigoId > 0 {
logrus.Tracef("Adding %d to deletable list", img.PiwigoId) logrus.Tracef("Adding %d to deletable list", img.PiwigoId)
@ -273,6 +278,7 @@ func updatePiwigoIdIfAlreadyUploaded(provider ImageMetadataProvider, piwigoCtx p
if err != nil { if err != nil {
return err return err
} }
for md5sum, piwigoId := range missingResults { for md5sum, piwigoId := range missingResults {
if piwigoId > 0 { if piwigoId > 0 {
logrus.Debugf("Setting piwigo id of %s to %d", md5sum, piwigoId) logrus.Debugf("Setting piwigo id of %s to %d", md5sum, piwigoId)
@ -287,3 +293,7 @@ func updatePiwigoIdIfAlreadyUploaded(provider ImageMetadataProvider, piwigoCtx p
return nil return nil
} }
func fileDidNotChange(metadata *ImageMetaData, file *localFileStructure.FilesystemNode) bool {
return metadata.LastChange.Equal(file.ModTime) && !metadata.DeleteRequired
}